[createReactClass] from ReactAndroid/src/androidTest/js/UIManagerTestModule.js#21702
Closed
ronal2do wants to merge 12 commits intofacebook:masterfrom
Closed
[createReactClass] from ReactAndroid/src/androidTest/js/UIManagerTestModule.js#21702ronal2do wants to merge 12 commits intofacebook:masterfrom
ronal2do wants to merge 12 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Oct 10, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
ronal2do
changed the title
analysis-bot
suggested changes
Oct 10, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
analysis-bot
suggested changes
Oct 10, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
analysis-bot
suggested changes
Oct 10, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
ronal2do
changed the title
RSNara
requested changes
Oct 10, 2018
Contributor
RSNara
left a comment
RSNara
left a comment
There was a problem hiding this comment.
Mostly good, but I think there's one problem. 🤔
elicwhite
reviewed
Oct 10, 2018
analysis-bot
suggested changes
Oct 11, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
analysis-bot
suggested changes
Oct 11, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@RSNara @TheSavior Thanks for your patience. |
Collaborator
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…#21702) Summary: Related to facebook#21581 . Removed createReactClass from ReactAndroid/src/androidTest/js/UIManagerTestModule.js Pull Request resolved: facebook#21702 Reviewed By: TheSavior Differential Revision: D10345717 Pulled By: RSNara fbshipit-source-id: 280f499abb2e2aa9f8ea25c3f8faaed8162e67d5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21581 .
Removed createReactClass from ReactAndroid/src/androidTest/js/UIManagerTestModule.js
Test Plan:
yarn prettier
yarn flow-check-android
Release Notes:
[GENERAL] [ENHANCEMENT] [ReactAndroid/src/androidTest/js/UIManagerTestModule.js] - remove createReactClass dependency